iRiver Clix 2GB
Samsung Blackjack II smartphone with 4GB microSD
2G iPod Touch 8GB
Still use all three depending on the situation, but the iPod currently gets the most use. The Touch is the most enjoyable, the Clix is useful when I want small and light, and the Blackjack is useful because it's always with me.
Gone from my 3 year old Archos 504 80gb with dodgy headphone socket (only comes through the right ear), to my new Samsung i8910HD 8gb phone with 16gb MicroSD card. 24gb is more than enough for me now