And it will likely be the end of windows as people switch to a non subscription based OS
Doubt it. Most large businesses already treat Microsoft products as subscription-based. If they make it cheap enough ($99 a year for "Windows 365+Office 365", or $25/year or less for Windows 365 alone,) I could see it working. And new PCs would come with a permanent license, as always. But people who want to stay "up to date" will fork over the fee.
Hell, Apple basically did that for a few years with their yearly $30 updates to OS X, people paid.
Will I do it? No. I'll upgrade to my Windows 10, and be done with it if that's the last non-subscription Windows. I kept a PC on Windows XP to the bitter end. I keep a PC on Windows 7, and will until its bitter end. I have a Windows 8.1 tablet - which will get upgraded to Windows 10. Other than that, I have a Mac and a Linux box.