Critique my design please

X

XamediX

2[H]4U
Joined
Oct 27, 2003
Messages
3,082
I am putting together a news feeder site and would like your feedback on the site. Tell me if anything loads slow, or any formatting breaks and also anything you think should or could be changed. I'm tough so rip it apart people.

http://newsmedia.j2ponline.com
 
Looks good but it doesn't validate - http://validator.w3.org/check?verbose=1&uri=http://newsmedia.j2ponline.com/

What is <center>? It's just sitting there all by itself.
If it's there to center your container div then just add margin: 0 auto; to #container.

<li> links need to be enclosed with <ul> or <ol> tags.

<div id=c_start>, <div id=c_ads>, <p id=footer> and others, have no ""

I could go on but the validator will catch all of this for you.
 
whew, i will go through all of that and see if I can get it validated. thanks though.
 
heh now the background on my container id doesnt work in FF anymore. but i have it down to one error!
 
You need to clear your floats. Make
</div>
</div>
</body></html>
read like:
Code: 
</div>
<div class="clear"></div>
</div>	
</body></html>
and add this to your CSS:
Code: 
.clear {
	clear: both;
}

You can goto http://www.cs.hmc.edu/~mbrubeck/clear-after/ to read about clearing floats.

Now you can use that margin: 0 auto; I told you about to center things.
 
thanks i just added a <br clear=both /> in between those divs. I forgot about clearing the floats. I now have one error on my validation. So now im looking for a new way to open links in a new window without using "target=new_". And I will look into the roman text/ backgound issue. Thanks again guys,

X
 
that header could use alot of work. is it supposed to look fast? the background is more of a distraction than anything.

I dont understand why you have the general news links in a div with a fixed height. it gives me a useless vertical scrollbar.
 
Typical link opening in a new window:

Code: 
<a href="http://www.yourlinkhere.com" target="_blank">Link Text</a>
 
XamediX said:
thanks i just added a <br clear=both /> in between those divs. I forgot about clearing the floats. I now have one error on my validation. So now im looking for a new way to open links in a new window without using "target=new_". And I will look into the roman text/ backgound issue. Thanks again guys,

X
Click to expand...
the only way to open in a new window without breaking validation is javascript.

Code: 
<a href="http://www.hardforum.com" onclick="window.open(this.href,'_blank');return false;">[H]ard|Forum</a>
 
Hey jizzypop,
the method I've shown is valid.
I have never seen it done with javascript, why would you?
 
thanks guys, i have the index all validated now. now for all the other pages. thanks again.

edit: hmm interesting, i didnt see the method using target=blank. I thought the whole target thing wasnt valid, but it seems there's two methods. I used the javascript method.
 
jizzypop said:
that header could use alot of work. is it supposed to look fast? the background is more of a distraction than anything.

I dont understand why you have the general news links in a div with a fixed height. it gives me a useless vertical scrollbar.
Click to expand...
Yea im working on the header. its more lack of ideas. I might make it look realllly simple and be done with it. And the background, i had wanted a soft newspaper design that didnt distract but it seems i need to mess with it more. Should I jus leave it solid color?

RE: fixed height on general news: That is because that newsfeed is usually 15 links long and somehow its only pulling like 5 at at time. I will fix this shortly.
 
Excavator said:
Hey jizzypop,
the method I've shown is valid.
I have never seen it done with javascript, why would you?
Click to expand...
target="_blank" does not validate (depending on which doctype you use).

Transitional it does, Strict it doesnt
 
So it does jizzypop! I did not realize that had be depreciated.
Learn something new every day.

I still think I would not use javascript... I would go with the transitional DTD instead.
 
You must log in or register to reply here.
Back
Top